Skip to content

fix(docs): resolve accessibility report issues - #2275

Merged
asblanco merged 11 commits into
mainfrom
dcormier/docs-a11y-report-fixes
Aug 5, 2026
Merged

fix(docs): resolve accessibility report issues#2275
asblanco merged 11 commits into
mainfrom
dcormier/docs-a11y-report-fixes

Conversation

@dancormier

@dancormier dancormier commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Fixes a few Stacks docs accessibility report issues found at https://accessibility.stackoverflow.net/products/stacks/automated
  • Adds accessible names/roles for affected examples and improves docs-only contrast on some text and links.
  • Wraps the toggle button demo in the standard example container (not strictly accessibility but just cleanup)

Testing

  • Load up the deploy preview
  • Ensure N/A in class tables on our component docs pages (such as Avatars) meet our contrast minimums
  • Ensure page description (below title) meets our contrast minimums
  • Ensure links within docs page text content (such as the Popper.js link in the Popover docs) meet our contrast minimums
  • Ensure each scrollable overflow atomic class example can be tabbed to and scrolled with arrow keys as appropriate (not all will be tabbable/scrollable)

@netlify

netlify Bot commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for stacks ready!

Name Link
🔨 Latest commit cc92b8d
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/6a732cd9b2f1e00008725b6e
😎 Deploy Preview https://deploy-preview-2275--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot

changeset-bot Bot commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cc92b8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dancormier
dancormier marked this pull request as ready for review May 20, 2026 16:24
@dancormier
dancormier requested a review from a team as a code owner May 20, 2026 16:24
@asblanco
asblanco enabled auto-merge (squash) June 22, 2026 16:19
asblanco
asblanco reviewed Jun 22, 2026
View reviewed changes
Comment thread packages/stacks-docs/src/app.css
dancormier and others added 2 commits June 29, 2026 14:59
@dancormier @asblanco
Update packages/stacks-docs/src/app.css
f122b63 
Co-authored-by: Andrea Sánchez Blanco <asanchezblanco@stackoverflow.com>
@dancormier
Merge branch 'main' into dcormier/docs-a11y-report-fixes
b5b9506
@dancormier
dancormier requested a review from asblanco June 29, 2026 18:59
@netlify

netlify Bot commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for stackoverflow-email ready!

Name Link
🔨 Latest commit cc92b8d
🔍 Latest deploy log https://app.netlify.com/projects/stackoverflow-email/deploys/6a732cd9d2fd3b0008b666db
😎 Deploy Preview https://deploy-preview-2275--stackoverflow-email.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@asblanco

asblanco commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

I’ve updated the branch with origin/main and resolved the resulting conflicts. The previous review feedback is now addressed.

The accessibility fixes include:

  • Documentation links had insufficient contrast because their CSS rule was incorrectly nested. The selector is now defined at the correct level, restoring the intended contrast.
  • Selected anchor examples used button semantics and an invalid aria-pressed attribute. These attributes were removed so the examples retain valid link semantics.
  • The regression tests inspected CSS selectors and source markup instead of behavior. They were replaced with a rendered-component test verifying that selected anchors remain links without invalid ARIA attributes.

The focused Stacks Svelte and documentation test suites pass.

auto-merge was automatically disabled August 5, 2026 12:34

Invalid email address

@asblanco
asblanco merged commit 6df2783 into main Aug 5, 2026
24 checks passed
@asblanco
asblanco deleted the dcormier/docs-a11y-report-fixes branch August 5, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asblanco asblanco asblanco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dancormier @asblanco